[wp-trac] [WordPress Trac] #54648: Improve filter to enable setting quality for each subsize image

WordPress Trac noreply at wordpress.org
Wed Sep 25 21:02:54 UTC 2024


#54648: Improve filter to enable setting quality for each subsize image
-------------------------------------+-------------------------------------
 Reporter:  Mte90                    |       Owner:  adamsilverstein
     Type:  enhancement              |      Status:  accepted
 Priority:  normal                   |   Milestone:  Future Release
Component:  Media                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-unit-    |     Focuses:  performance,
  tests changes-requested            |  sustainability
-------------------------------------+-------------------------------------
Changes (by joemcgill):

 * milestone:  6.7 => Future Release


Comment:

 I spent some time reviewing [https://github.com/WordPress/wordpress-
 develop/pull/2189#issuecomment-2315716790 PR #2189] today and while the
 change itself is fine, it doesn't seem to address the requirements of this
 issue. I have confirmed that the `set_quality()` method only gets called
 when the image editor is loaded and that value persists for any sub-size
 that is generated from the original image.

 To address this issue, I think we would need to add some logic to the
 `make_subsize()` methods to set the quality for each sub-size before they
 are resized. Given that we're this close to Beta 1, I'm going to punt this
 to a future release and it can be pulled back into a future milestone
 whenever someone is planning to work on it further.

 All the workflow keywords still seem valid.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54648#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list