[wp-trac] [WordPress Trac] #60629: PHP Fatal error: Uncaught TypeError: gmdate(): Argument #2 ($timestamp) must be of type ?int, string given in wp-admin/includes/dashboard.php:1025

WordPress Trac noreply at wordpress.org
Wed Sep 18 21:34:03 UTC 2024


#60629: PHP Fatal error:  Uncaught TypeError: gmdate(): Argument #2 ($timestamp)
must be of type ?int, string given in wp-admin/includes/dashboard.php:1025
------------------------------------+--------------------------------
 Reporter:  vanhoucke               |       Owner:  hellofromTonya
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  6.7
Component:  Date/Time               |     Version:  6.4.3
 Severity:  normal                  |  Resolution:
 Keywords:  php80 has-patch commit  |     Focuses:  php-compatibility
------------------------------------+--------------------------------
Changes (by hellofromTonya):

 * keywords:  php80 => php80 has-patch commit


Comment:

 [https://github.com/WordPress/wordpress-
 develop/pull/7233#pullrequestreview-2313843980 PR 7233] is ready for
 commit. Spoke with @peterwilsoncc who will do the commit.

 Copying my approval in the PR:

 [As I previously noted](https://github.com/WordPress/wordpress-
 develop/pull/7233#issuecomment-2327431927), this baby step resolves the
 immediate issue and uses the existing pattern committed in
 https://core.trac.wordpress.org/changeset/58923.

 Ideally these changes would have full test coverage. That said, in talking
 with @peterwilsoncc, he shared:

 >The tests are there for current features and the upgrade tests should
 catch anything in the ugrade routine

 Getting this committed early enough gives a longer soak time to hopefully
 uncover any issues.

 I think this is ready enough for commit ✅

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60629#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list