[wp-trac] [WordPress Trac] #56358: PHP8 TypeError on current_time( 'timestamp' ) if timezone is set to GMT / 0

[WordPress Trac]

#56358: PHP8 TypeError on current_time( 'timestamp' ) if timezone is set to GMT / 0
------------------------------------+--------------------------------
 Reporter:  toastercookie           |       Owner:  hellofromTonya
     Type:  defect (bug)            |      Status:  reviewing
 Priority:  normal                  |   Milestone:  6.7
Component:  Date/Time               |     Version:  6.0
 Severity:  minor                   |  Resolution:
 Keywords:  php80 has-patch commit  |     Focuses:  php-compatibility
------------------------------------+--------------------------------
Changes (by hellofromTonya):

 * keywords:  php80 has-patch => php80 has-patch commit
 * status:  assigned => reviewing


Comment:

 [https://github.com/WordPress/wordpress-
 develop/pull/7233#pullrequestreview-2313843980 PR 7233] is ready for
 commit. Spoke with @peterwilsoncc who will do the commit.

 Copying my approval in the PR:

 [As I previously noted](https://github.com/WordPress/wordpress-
 develop/pull/7233#issuecomment-2327431927), this baby step resolves the
 immediate issue and uses the existing pattern committed in
 https://core.trac.wordpress.org/changeset/58923.

 Ideally these changes would have full test coverage. That said, in talking
 with @peterwilsoncc, he shared:

 >The tests are there for current features and the upgrade tests should
 catch anything in the ugrade routine

 Getting this committed early enough gives a longer soak time to hopefully
 uncover any issues.

 I think this is ready enough for commit ✅

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56358#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform