[wp-trac] [WordPress Trac] #60369: Shortcut for Select Button in Media Library

WordPress Trac noreply at wordpress.org
Tue Sep 17 21:23:51 UTC 2024


#60369: Shortcut for Select Button in Media Library
-----------------------------------+----------------------------
 Reporter:  hirschferkel           |       Owner:  antpb
     Type:  enhancement            |      Status:  assigned
 Priority:  normal                 |   Milestone:  6.7
Component:  Media                  |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  accessibility
-----------------------------------+----------------------------

Comment (by plaidharper):

 == Test Report
 My understanding of this ticket is that ctrl/cmd + enter is used to insert
 already selected images into a post/page and not used to do the actual
 selecting. Below is my test.

 === Environment
 Server: Apache (Linux)
 WordPress: 6.7-alpha-58576-src
 Browser: Chrome Version 127.0.6533.89 & Safari Version 17.6
 (19618.3.11.11.5)
 OS: 14.6
 Theme: Twenty Twenty-Four
 Plugins: None activated & Classic Editor activated

 === Steps to Reproduce
 1) Add multiple images to the Media Library
 2) Navigate to {{{Pages > Add New}}}
 3) Add an image block, select Media Library, select an image, hit ctrl +
 enter, take note whether the key combination selects/deselects or inserts
 into the page
 4) Add a gallery block, select Media Library, select multiple images, hit
 ctrl + enter, take note whether the key combination selects/deselects or
 inserts into the page
 5) Add a cover block, select Media Library, select an image , hit ctrl +
 enter, take note whether the key combination selects/deselects or inserts
 into the page
 6) Activate Classic Editor plugin
 7) Navigate to {{{Setting > Writing}}}
 8) Set Default editor for all users to Classic Editor
 9) Navigate to {{{Pages > Add New}}}
 10) Click Add Media Button, select an image, hit ctrl + enter,take note
 whether the key combination selects/deselects or inserts into the page
 11) Repeat step 9 but select multiple images
 12) Click Add Media Button, click Create gallery in the left hand menu,
 select multiple images, hit ctrl + enter, take note whether the key
 combination selects/deselects or inserts into the page
 13) Click Add Media Button, click Feature image in the left hand menu,
 select an image, hit ctrl + enter, take note whether the key combination
 selects/deselects or inserts into the page
 14) Apply
 https://core.trac.wordpress.org/attachment/ticket/60369/60369.3.patch
 15) Run {{{npm run build:dev}}}
 16) Navigate to {{{Setting > Writing}}}
 17) Set Default editor for all users to Block Editor
 18) Repeat steps 1 thru 13


 === Results
 1) Before applying patch ctrl + enter '''does not''' insert selected
 images into the page
 2) After applying patch, ctrl + enter '''does''' insert selected images
 into the page  ✅

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60369#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list