[wp-trac] [WordPress Trac] #59207: Twenty Thirteen: correct styling for Button & File block links in front-end widget areas (Footer & Sidebar)

WordPress Trac noreply at wordpress.org
Tue Sep 17 18:29:05 UTC 2024


#59207: Twenty Thirteen: correct styling for Button & File block links in front-end
widget areas (Footer & Sidebar)
-------------------------------------+-----------------------------
 Reporter:  shailu25                 |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Bundled Theme            |     Version:  5.8
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, css
-------------------------------------+-----------------------------
Changes (by sabernhardt):

 * milestone:  Awaiting Review => Future Release


Comment:

 Thanks for the patch!

 I simplified the selectors in [attachment:"59207.1.patch"] so the rules
 would apply in post content or a widget:
 - Color presets have `:root` instead of `.entry-content`.
 - Button block styles replace `.entry-content` with `.wp-block-button` if
 they did not have that previously. If the selector already included the
 class, the patch replaces `.entry-content` with `:root`.

 To make the theme color presets work in footer widgets, the link selector
 uses `.site-footer .widget :where(a)` for a specificity of `0-2-0`. Color
 rulesets such as `:root .has-dark-gray-color` have the same specificity
 later.

 Editor styles:
 - Shail corrected the orange for Button blocks with the Outline style (in
 59207.patch), and I edited the color in the existing ruleset.
 - The File block Download link has a 2-pixel radius, and the patch updates
 the editor styles for that.
 - I did not increase the specificity of the color rules for the File
 block, however. That mismatch comes from the fallback `classic-theme-
 styles`, which should be enqueued earlier (#61892).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59207#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list