[wp-trac] [WordPress Trac] #61898: Use --wp-admin--admin-bar--height variable in css
WordPress Trac
noreply at wordpress.org
Tue Sep 17 15:54:12 UTC 2024
#61898: Use --wp-admin--admin-bar--height variable in css
-------------------------+-----------------------------
Reporter: tdrayson | Owner: SergeyBiryukov
Type: enhancement | Status: reviewing
Priority: normal | Milestone: 6.7
Component: Toolbar | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: css
-------------------------+-----------------------------
Comment (by sabernhardt):
#54032 requested a similar change, mainly for the front-end bump, and I
did not want to break the front end in old browsers then. I still think
the front end needs a separate decision, and maybe later (though it has
been two years already).
== Fallback value
An undefined `--wp-admin--admin-bar--height` variable should be rare, but
sites technically can deregister the core 'admin-bar' stylesheet and
replace it. Most of the directory's
[https://wpdirectory.net/search/01J806CEYJCVBT4XQ5M5N18852 plugins that
deregister the stylesheet] remove it without replacing the styles.
I do not have a preference between `32px` or `46px`, but I think the
fallback should be consistent everywhere the property is used. PR 7358 has
`32px` because I already chose that in patches for #41155 and #54032.
== Editor skip link
A fix for the mostly hidden skip links might belong in the Gutenberg
styles instead, but I added the adjustment in `common.css`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/61898#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list