[wp-trac] [WordPress Trac] #56748: Twenty Twenty-One: Image stuck to text in responsive sizes

WordPress Trac noreply at wordpress.org
Fri Sep 13 00:55:45 UTC 2024


#56748: Twenty Twenty-One: Image stuck to text in responsive sizes
-------------------------------------------------+-------------------------
 Reporter:  sagarladani                          |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Bundled Theme                        |     Version:  5.6
 Severity:  normal                               |  Resolution:
 Keywords:  2nd-opinion has-patch needs-testing  |     Focuses:  css
-------------------------------------------------+-------------------------
Changes (by sabernhardt):

 * keywords:  2nd-opinion has-patch => 2nd-opinion has-patch needs-testing


Comment:

 I built on [attachment:"56748.RTL-fix-only.patch"] for the RTL styles.
 - The theme needs `/*rtl:ignore*/` comments for the `--global--spacing-
 horizontal` margin.
 - I retained the zero margin rulesets from that patch, even though GB47617
 should make those unnecessary with the latest versions of WordPress.
 - PR 7335 updates editor styles to reflect the same margins, with the
 `/*rtl:ignore*/` comments for **any** aligned block and the zero margin
 applied only to the Image block. (The zero margins may become unnecessary
 in the future with GB65249.)

 I also wanted to add space between images and text, as that was the
 original intent of this ticket. A pseudo-element might help when images
 are small and do not have a caption. The impact with larger images and
 with captioned images seems minor.

 The pseudo-element did not work for me in the editor, so it is not
 included there.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56748#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list