[wp-trac] [WordPress Trac] #62035: SITE_ID_CURRENT_SITE broken in 6.3 or later

WordPress Trac noreply at wordpress.org
Fri Sep 13 00:54:20 UTC 2024


#62035: SITE_ID_CURRENT_SITE broken in 6.3 or later
-------------------------------------------------+-------------------------
 Reporter:  scottculverhouse                     |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  6.7
Component:  Networks and Sites                   |     Version:  6.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:  multisite
  testing                                        |
-------------------------------------------------+-------------------------
Changes (by ironprogrammer):

 * keywords:  has-patch has-unit-tests => has-patch has-unit-tests needs-
     testing


Comment:

 Replying to [comment:6 SergeyBiryukov]:
 > [attachment:"62035.diff"] fixes the issue in my testing, but this could
 use some unit tests.

 Thanks for the patch, @SergeyBiryukov! I've submitted
 [https://github.com/WordPress/wordpress-develop/pull/7345 PR #7345] which
 includes a unit test for the type of `WP_Network::id`. The other
 consideration might be to verify that `WP_Network::blog_id` is `string`
 (enforcing future backward compat), but I wanted to seek input before
 adding that.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62035#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list