[wp-trac] [WordPress Trac] #62032: Fixing the non yoda conditions in ms-functions.php

WordPress Trac noreply at wordpress.org
Wed Sep 11 21:38:05 UTC 2024


#62032: Fixing the non yoda conditions in ms-functions.php
--------------------------------+------------------------------------------
 Reporter:  debarghyabanerjee   |       Owner:  audrasjb
     Type:  enhancement         |      Status:  reviewing
 Priority:  normal              |   Milestone:  6.7
Component:  Networks and Sites  |     Version:
 Severity:  minor               |  Resolution:
 Keywords:  has-patch           |     Focuses:  multisite, coding-standards
--------------------------------+------------------------------------------

Comment (by debarghyabanerjee):

 Hi @jrf, I was going through the core's codebase and found that in most of
 the places,

 {{{#!php
 <?php
 if ( ! is_email( $email ) ) {
 }}}


 is used, so in my opinion we should keep this to keep the check consistent
 across the codebase, however I can change the checks as per your
 suggestion, please let me know, what are your thoughts on this. Thanks.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62032#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list