[wp-trac] [WordPress Trac] #62035: BLOG_ID_CURRENT_SITE broken in 6.3 or later

[WordPress Trac]

#62035: BLOG_ID_CURRENT_SITE broken in 6.3 or later
--------------------------------+-----------------------------
 Reporter:  scottculverhouse    |      Owner:  (none)
     Type:  defect (bug)        |     Status:  new
 Priority:  normal              |  Milestone:  Awaiting Review
Component:  Networks and Sites  |    Version:  6.3
 Severity:  normal              |   Keywords:
  Focuses:  multisite           |
--------------------------------+-----------------------------
 We set the constants

 {{{#!php
 <?php
 define('SITE_ID_CURRENT_SITE', 1);
 define('BLOG_ID_CURRENT_SITE', 2);
 }}}

 This was working up until 6.3 where the following
 [https://github.com/WordPress/wordpress-
 develop/commit/a8d12183f23694718756c9e84338e12342b2fcb9 commit] was added

 I believe this is a bug for the following reasons

 1. The typecast of SITE_ID_CURRENT_SITE  to int
 2. along with the strict comparison
 3. and $this->id is always a string

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62035>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform