[wp-trac] [WordPress Trac] #61987: Removed Unused Arguments From _wp_filter_build_unique_id Function

WordPress Trac noreply at wordpress.org
Wed Sep 11 01:49:14 UTC 2024


#61987: Removed Unused Arguments From _wp_filter_build_unique_id Function
--------------------------------------+------------------------------
 Reporter:  wpdebuglog                |       Owner:  (none)
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Plugins                   |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------------

Comment (by dd32):

 Replying to [comment:5 jrf]:
 > What about adding a default value of `0` for the `$priority` parameter
 though ? That would make the parameter optional and could allow for
 simplifying calls to the function by removing the need to pass ''one'' of
 the two deprecated/unused parameters.

 I'd go for `10` since that's the default priority elsewhere, but that
 feels like a reasonable middle-ground.

 Although, it's such a minor change that doesn't really make the function
 nicer to use, since it's got an unused parameter first.. kinda feels like
 "what's the point in changing anything" :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61987#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list