[wp-trac] [WordPress Trac] #62032: Fixing the non yoda conditions in ms-functions.php

[WordPress Trac]

#62032: Fixing the non yoda conditions in ms-functions.php
-----------------------------------------+-----------------------------
 Reporter:  debarghyabanerjee            |      Owner:  (none)
     Type:  enhancement                  |     Status:  new
 Priority:  normal                       |  Milestone:  Awaiting Review
Component:  Networks and Sites           |    Version:
 Severity:  minor                        |   Keywords:
  Focuses:  multisite, coding-standards  |
-----------------------------------------+-----------------------------
 There are two functions inside ms-functions.php, where if check doesn't
 have Yoda condition check implemented and also strict comparison is not
 added.

 The two functions are:

 1. newuser_notify_siteadmin();
 2. newblog_notify_siteadmin();

 The if check is as follows:

 {{{#!php
 <?php
 if ( is_email( $email ) == false ) {
     return false;
 }
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62032>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform