[wp-trac] [WordPress Trac] #58171: Twenty Nineteen: The pullquote block appears to have a problem when selecting the text color.

WordPress Trac noreply at wordpress.org
Thu Sep 5 16:16:22 UTC 2024


#58171: Twenty Nineteen: The pullquote block appears to have a problem when
selecting the text color.
-------------------------------------------------+-------------------------
 Reporter:  utsav72640                           |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Bundled Theme                        |     Version:  6.2
 Severity:  normal                               |  Resolution:
 Keywords:  needs-design-feedback has-patch      |     Focuses:  ui,
  needs-testing                                  |  administration
-------------------------------------------------+-------------------------

Comment (by wildworks):

 @viralsampat Thank you for submitting the patch.

 The CSS files for the Twenty Nineteen theme are automatically generated
 via `node-sass`. Therefore, we cannot edit the CSS files directly.

 We need to perform the following steps:

 - Go to the theme directory and run `npm install` to install the npm
 dependencies
 - Make changes to the scss file
 - Run `npm run build` or `npm run watch` to generate the CSS file

 Also, I think it's best to avoid using the `!important` rule as much as
 possible.

 From what I've researched briefly, we may be able to solve the problem by
 adding a style like the one below here: https://github.com/WordPress
 /wordpress-develop/blob/c8d4bc734fcf35c34f042b29d0897a955680ac0b/src/wp-
 content/themes/twentynineteen/style-editor.scss#L543

 {{{
 .wp-block-pullquote {
         // ...
         &.has-text-color {
                 p,
                 .wp-block-pullquote__citation {
                         color: inherit;
                 }
         }
 }
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58171#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list