[wp-trac] [WordPress Trac] #61103: update all update_option calling in core to set the autoload option

[WordPress Trac]

#61103: update all update_option calling in core to set the autoload option
--------------------------------+--------------------------
 Reporter:  pbearne             |       Owner:  flixos90
     Type:  defect (bug)        |      Status:  closed
 Priority:  normal              |   Milestone:  6.7
Component:  Options, Meta APIs  |     Version:
 Severity:  normal              |  Resolution:  fixed
 Keywords:  has-patch early     |     Focuses:  performance
--------------------------------+--------------------------
Changes (by flixos90):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"58975" 58975]:
 {{{
 #!CommitTicketReference repository="" revision="58975"
 Options, Meta APIs: Explicitly pass `$autoload` parameter to when
 potentially adding new options.

 It is recommended that for every option it is explicitly set whether to
 autoload it or not. This changeset updates relevant `update_option()` and
 `add_option()` calls.

 Note that the `$autoload` parameter is only needed for `update_option()`
 if the option is potentially not present yet, i.e. the call will pass
 through to `add_option()`. Since WordPress core adds the majority of its
 options to the database during installation, only `update_option()` calls
 for dynamically added options need to be modified, which is what this
 changeset does.

 As part of revisiting the autoload values for dynamically added WordPress
 core options, this changeset modifies some options to no longer be
 autoloaded, since they are only accessed in a few specific places that are
 not relevant for a regular request. These options are:
 * `recently_activated`
 * `_wp_suggested_policy_text_has_changed`
 * `{upgradeLock}.lock`
 * `dashboard_widget_options`
 * `ftp_credentials`
 * `adminhash`
 * `nav_menu_options`
 * `wp_force_deactivated_plugins`
 * `delete_blog_hash`
 * `allowedthemes`
 * `{sessionId}_paused_extensions`
 * `recovery_keys`
 * `https_detection_errors`
 * `fresh_site`

 An upgrade routine is present as well that sets those options to no longer
 autoload for existing sites.

 Props pbearne, flixos90, mukesh27, swissspidy, SergeyBiryukov, joemcgill,
 adamsilverstein.
 Fixes #61103.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61103#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform