[wp-trac] [WordPress Trac] #61769: Global Styles: Prevent empty CSS rules and malformed selectors for custom css for blocks

WordPress Trac noreply at wordpress.org
Tue Sep 3 16:04:42 UTC 2024


#61769: Global Styles: Prevent empty CSS rules and malformed selectors for custom
css for blocks
-------------------------------------------------+-------------------------
 Reporter:  aaronrobertshaw                      |       Owner:
                                                 |  hellofromTonya
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.6.2
Component:  Editor                               |     Version:  6.6
 Severity:  normal                               |  Resolution:
 Keywords:  gutenberg-merge has-patch has-unit-  |     Focuses:
  tests has-testing-info commit fixed-major      |
  dev-feedback                                   |
-------------------------------------------------+-------------------------

Old description:

> This ticket tracks the backporting of PHP files for the following
> Gutenberg changes:
> - https://github.com/WordPress/gutenberg/pull/63980
>
> These changes fix two issues with the generation of custom css for blocks
> with Global Styles.
>
> 1. Empty CSS rules e.g. `:root :where(.wp-block-heading){}`
> 2. Malformed pseudo element selectors `:root :where(.wp-block-
> heading::before)`

New description:

 This ticket tracks the merging of PHP files for the following Gutenberg
 changes:
 - https://github.com/WordPress/gutenberg/pull/63980

 These changes fix two issues with the generation of custom css for blocks
 with Global Styles.

 1. Empty CSS rules e.g. `:root :where(.wp-block-heading){}`
 2. Malformed pseudo element selectors `:root :where(.wp-block-
 heading::before)`

--

Comment (by hellofromTonya):

 Pinging committers involved in this change for a 2nd committer sign-off to
 backport it to the 6.6. branch for 6.6.2 RC1 on Sep 4th.

 @aaronrobertshaw @andrewserong @talldanwp

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61769#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list