[wp-trac] [WordPress Trac] #53323: Place Hello Dolly in containing folder

WordPress Trac noreply at wordpress.org
Sun Sep 1 22:43:41 UTC 2024


#53323: Place Hello Dolly in containing folder
-------------------------------------------------+-------------------------
 Reporter:  afragen                              |       Owner:  afragen
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.7
Component:  Upgrade/Install                      |     Version:  5.8
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by peterwilsoncc):

 To summarize the discussion on the PR:

 * there will need to be some code to prevent the relocation of the plugin
 from causing it to be deactivated. The plugin has 700K+ active installs.
 * the upgrade routine runs too late to modify the active plugins list, by
 the time it runs the plugin will have been deactivated and the opportunity
 missed
 * to avoid the need to maintain the plugin in two locations, the hello-
 dolly folder can be added as an external and added during the build
 process similar to Akismet. I've started
 [https://wordpress.slack.com/archives/C02QB8GMM/p1724717102946269
 discussions with the meta team] about the process here

 If needs be it might be possible to add some snowflake code to
 `wp_get_active_and_valid_plugins()` to account for the relocation but it
 would be optimal if that could be avoided.

 There is some snowflake code (either in WP or the upgrade API) to keep the
 plugin active when updated via the dashboard so there might be some prior
 art that can used.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53323#comment:44>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list