[wp-trac] [WordPress Trac] #60045: Change to add_new label displays wrong label for old post types

[WordPress Trac]

#60045: Change to add_new label displays wrong label for old post types
---------------------------------------------+----------------------------
 Reporter:  smerriman                        |       Owner:  rcreators
     Type:  defect (bug)                     |      Status:  closed
 Priority:  normal                           |   Milestone:  6.7
Component:  Administration                   |     Version:  6.4
 Severity:  normal                           |  Resolution:  fixed
 Keywords:  good-first-bug has-patch commit  |     Focuses:  accessibility
---------------------------------------------+----------------------------
Changes (by joedolson):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"59161" 59161]:
 {{{
 #!CommitTicketReference repository="" revision="59161"
 Administration: Switch core post type labels to `add_new_item`.

 In [56515], the default value of `Add New` was changed to "Add New Post /
 Add New Page". This caused problems with post types where `add_new` was
 not declared.

 Change core usage to reference the `add_new_item` value and revert the
 default value of `add_new` back to "Add New / Add New". This retains the
 accessibility advantages without creating counter intuitive usage of the
 `add_new` key.

 With this change, post types registered with no `add_new` key will be
 unimpacted in core, and post types registered with no `add_new_item` key
 will use the default "Add New Post", which is not a change from the
 current state.

 Props smerriman, afercia, rcreators, joedolson, eclev91, johnbillion.
 Fixes #60045.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60045#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform