[wp-trac] [WordPress Trac] #62519: Trigger _doing_it_wrong in _load_textdomain_just_in_time() even when there are no translations (was: _doing_it_wrong misplaced in the _load_textdomain_just_in_time() function)

[WordPress Trac]

#62519: Trigger _doing_it_wrong in _load_textdomain_just_in_time() even when there
are no translations
-----------------------------+-----------------------------
 Reporter:  babelhalsupport  |       Owner:  (none)
     Type:  enhancement      |      Status:  reopened
 Priority:  normal           |   Milestone:  Future Release
Component:  I18N             |     Version:  6.7
 Severity:  normal           |  Resolution:
 Keywords:  dev-feedback     |     Focuses:
-----------------------------+-----------------------------
Changes (by swissspidy):

 * status:  closed => reopened
 * resolution:  worksforme =>
 * milestone:   => Future Release
 * keywords:  has-patch => dev-feedback
 * type:  defect (bug) => enhancement


Comment:

 Thanks for the clarification. I see where you're coming from. In this
 scenario you might indeed be wondering why a string wasn't translated.

 The problem there is that this would also cause a warning if there are no
 translations installed yet, for example if the locale is set to en_US, or
 if the domain is spelled incorrectly.

 Adding a notice even in such cases would be very noisy.

 I think one way to mitigate this is by landing #62244 first, which removes
 the need to call `load_plugin_textdomain()` at all. This reduces the
 likelihood of this warning being triggered for custom plugins.

 Second, we might want to give this a little bit more time before landing,
 maybe doing it only in a subsequent release.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62519#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform