[wp-trac] [WordPress Trac] #61331: Plugins: Revert 6.5.3 changes for showing an admin notice on successful activation.

WordPress Trac noreply at wordpress.org
Thu May 30 16:57:56 UTC 2024


#61331: Plugins: Revert 6.5.3 changes for showing an admin notice on successful
activation.
----------------------------+----------------------
 Reporter:  hellofromTonya  |      Owner:  (none)
     Type:  defect (bug)    |     Status:  assigned
 Priority:  normal          |  Milestone:  6.5.4
Component:  Plugins         |    Version:  6.5.3
 Severity:  normal          |   Keywords:
  Focuses:                  |
----------------------------+----------------------
 With a new direction in the 6.5.4 minor to restore the Activate button's
 `href` (see #61319 / [58250]), the changesets committed for 6.5.3 (see
 #60992) are now dead code and will not be rendered.

 After discussing in
 [https://wordpress.slack.com/archives/C02RQBWTW/p1717082793023699
 Make/Core slack], consensus is to revert both [58081] (on `trunk`) and
 [58083] (on 6.5 branch).

 [https://wordpress.slack.com/archives/C02RQBWTW/p1717083493987049?thread_ts=1717082793.023699&cid=C02RQBWTW
 Quoting] @costdev:
 >Sure, 68081 (trunk) and 68083 (6.5) should be reverted. They are part of
 a solution that did not achieve the intended result fully, and have been
 replaced, not extended, with a different solution for 6.5. If we want to
 introduce them later, then we still have the code stored in history to
 save us some time.

 As @jorbin
 [https://wordpress.slack.com/archives/C02RQBWTW/p1717084842892619?thread_ts=1717082793.023699&cid=C02RQBWTW
 noted]:
 >I'm not sure if it will be a clean revert since [58250] also changed some
 of these lines, but I would support reverting the functionality

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61331>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list