[wp-trac] [WordPress Trac] #60992: Plugin management: AJAX plugin activation consequences
WordPress Trac
noreply at wordpress.org
Thu May 30 16:07:29 UTC 2024
#60992: Plugin management: AJAX plugin activation consequences
-------------------------------------------------+-------------------------
Reporter: jeherve | Owner: jorbin
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 6.5.3
Component: Plugins | Version: 6.5
Severity: normal | Resolution:
Keywords: has-patch needs-testing has- | Focuses:
testing-info needs-design-feedback i18n- |
change |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):
* keywords:
has-patch needs-testing has-testing-info needs-design-feedback commit
i18n-change fixed-major dev-reviewed
=>
has-patch needs-testing has-testing-info needs-design-feedback i18n-
change
* status: closed => reopened
* resolution: fixed =>
Comment:
With a new direction in the 6.5.4 minor to restore the Activate button's
`href` (see #61319 / [58250]), the changesets committed for 6.5.3 are now
dead code and will not be rendered.
After discussing in
[https://wordpress.slack.com/archives/C02RQBWTW/p1717082793023699
Make/Core slack], consensus is to revert both [58083] and [58083].
[https://wordpress.slack.com/archives/C02RQBWTW/p1717083493987049?thread_ts=1717082793.023699&cid=C02RQBWTW
Quoting] @costdev:
>Sure, 68081 (trunk) and 68083 (6.5) should be reverted. They are part of
a solution that did not achieve the intended result fully, and have been
replaced, not extended, with a different solution for 6.5. If we want to
introduce them later, then we still have the code stored in history to
save us some time.
As @jorbin
[https://wordpress.slack.com/archives/C02RQBWTW/p1717084842892619?thread_ts=1717082793.023699&cid=C02RQBWTW
noted]:
>I'm not sure if it will be a clean revert since [58250] also changed some
of these lines, but I would support reverting the functionality
I'm reopening this ticket to prepare the reverts. I may need to create a
PR first if the reverts are not clean, as Jorbin noted.
Also resetting the keywords.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/60992#comment:101>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list