[wp-trac] [WordPress Trac] #61294: Plugin Dependencies: Ensure dependency detection for newly installed plugins

[WordPress Trac]

#61294: Plugin Dependencies: Ensure dependency detection for newly installed
plugins
-----------------------------------------------+---------------------------
 Reporter:  costdev                            |       Owner:
                                               |  hellofromTonya
     Type:  defect (bug)                       |      Status:  closed
 Priority:  normal                             |   Milestone:  6.5.4
Component:  Plugins                            |     Version:  6.5
 Severity:  normal                             |  Resolution:  fixed
 Keywords:  has-patch has-testing-info commit  |     Focuses:
-----------------------------------------------+---------------------------
Changes (by hellofromTonya):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"58252" 58252]:
 {{{
 #!CommitTicketReference repository="" revision="58252"
 Plugin Dependencies: Ensure dependency detection for newly installed
 plugins.

 Resolves a bug by first initializing in the AJAX callback
 `WP_Plugin_Dependencies::check_plugin_dependencies_during_ajax()`.

 More details:

 [57658] removed auto-deactivation and bootstrapping logic from the Plugin
 Dependencies feature. In doing so, initialization calls were added to
 various locations in Core to ensure dependencies were detected and ready
 to be checked. However, an initialization call was missed in the AJAX
 callback before checking plugin dependencies.

 This means that a plugin's dependencies may not be detected, and lead to a
 false positive, which in turn allows the user to click Activate only to
 see a failure message.

 Follow-up to [57658].

 Props kevinwhoffman, costdev, afragen.
 Fixes #61294.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61294#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform