[wp-trac] [WordPress Trac] #61290: Twenty Eleven: Add theme support for HTML5

WordPress Trac noreply at wordpress.org
Sat May 25 17:10:52 UTC 2024


#61290: Twenty Eleven: Add theme support for HTML5
---------------------------+-----------------------------
 Reporter:  poena          |       Owner:  (none)
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  Future Release
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  2nd-opinion    |     Focuses:
---------------------------+-----------------------------
Changes (by sabernhardt):

 * keywords:   => 2nd-opinion
 * type:  defect (bug) => enhancement
 * milestone:  Awaiting Review => Future Release


Old description:

> By proactively adding theme support for HTML5 and fixing any styling
> issues,
> we can prevent problems if the HTML5 theme support becomes the default
> for all themes.
>
> ''But not least, it updates the markup to more modern standards.''
>
> Without HTML5 support enabled, the comment form in Twenty Elven uses the
> text input field for the email input.
>
> With HTML5 support enabled, the comment form is switched to using the
> email input field, and this changes the positioning of the field,
> breaking the layout.
>
> Related to https://core.trac.wordpress.org/ticket/61183
> Follow up to https://core.trac.wordpress.org/ticket/20579

New description:

 By proactively adding theme support for HTML5 and fixing any styling
 issues,
 we can prevent problems if the HTML5 theme support becomes the default for
 all themes.

 ''But not least, it updates the markup to more modern standards.''

 Without HTML5 support enabled, the comment form in Twenty Eleven uses the
 text input field for the email input.

 With HTML5 support enabled, the comment form is switched to using the
 email input field, and this changes the positioning of the field, breaking
 the layout.

 Related to #61183
 Follow up to #20579

--

Comment:

 I uploaded a patch to test more elements.

 In addition to the comment form input fields:
 - the `gallery` shortcode output would lose the column grid
 - the `caption` shortcode would change its width (possibly only a minor
 difference)

 The classic navigation widgets looked the same with the `nav` element at
 first glance: Archives, Categories, Meta, Navigation Menu, Pages, Recent
 Comments, Recent Posts, RSS and Tag Cloud. For the search form, Twenty
 Eleven has its own `searchform.php` template.

 Child themes that replace the main stylesheet would need to update their
 styles if the theme support is added (unless the theme also overrides the
 `twentyeleven_setup()` function or the site does not enable comments).

 I think it would be worth at least adding the two input types in the
 stylesheet for the comment form, even if the support is not officially
 added in `twentyeleven_setup()`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61290#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list