[wp-trac] [WordPress Trac] #61294: Plugin Dependencies: Ensure dependency detection for newly installed plugins

WordPress Trac noreply at wordpress.org
Sat May 25 01:11:37 UTC 2024


#61294: Plugin Dependencies: Ensure dependency detection for newly installed
plugins
-------------------------+-------------------------------------------------
 Reporter:  costdev      |      Owner:  (none)
     Type:  defect       |     Status:  new
  (bug)                  |
 Priority:  normal       |  Milestone:  6.5.4
Component:  Plugins      |    Version:  6.5
 Severity:  normal       |   Keywords:  has-patch needs-testing has-
  Focuses:               |  testing-info
-------------------------+-------------------------------------------------
 [57658] removed auto-deactivation and bootstrapping logic from the Plugin
 Dependencies feature. In doing so, initialization calls were added to
 various locations in Core to ensure dependencies were detected and ready
 to be checked. However, an initialization call was missed in the AJAX
 callback before checking plugin dependencies.

 This means that a plugin's dependencies may not be detected, and lead to a
 false positive, which in turn allows the user to click `Activate` only to
 see a failure message.

 **Steps to reproduce**
 1. Go to `Plugins > Add New Plugin`.
 x. Search `WooCommerce`, and find a plugin that requires it.
 x. Click on WooCommerce's "More details" link in the "Additional plugins
 are required" notice.
 x. Click `Install Now` in the modal.
 x. Close the modal.
 x. Refresh.
 x. Click `Install Now` on the dependent.
 x. 🐞 Once installed, it'll have a clickable `Activate` button, and when
 clicked, will fail.
 x. 🐞 Opening DevTools > Network, the final admin-ajax.php entry will show
 a response including "This has no required plugins", which is obviously
 incorrect.

 When testing a patch to validate it works as expected:
 - ✅ The `Activate` button should not be clickable.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61294>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list