[wp-trac] [WordPress Trac] #57725: Use of rand() function instead of wp_rand()

WordPress Trac noreply at wordpress.org
Fri May 24 11:57:00 UTC 2024


#57725: Use of rand() function instead of wp_rand()
-------------------------------------+-------------------------------------
 Reporter:  haritpanchal             |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Filesystem API           |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-testing-   |     Focuses:  performance, coding-
  info 2nd-opinion changes-          |  standards
  requested                          |
-------------------------------------+-------------------------------------

Comment (by naeemhaque):

 Hello @costdev, I've tested the patch & it's working as expected results.

 == Bug Report

 === Description
 This report validates whether the indicated patch works as expected.
 Patch tested:
 https://core.trac.wordpress.org/attachment/ticket/57725/57725.diff

 === Environment
 - WordPress: 6.6-alpha-57778-src
 - PHP: 7.4.33
 - Server: nginx/1.23.2
 - Database: mysqli (Server: 8.0.36 / Client: mysqlnd 7.4.33)
 - Browser: Chrome 124.0.0.0
 - OS: macOS
 - Theme: Twenty Twenty-Four 1.0
 - MU Plugins: None activated
 - Plugins:
   * Test Reports 1.1.0

 === Steps to Reproduce
 1. Apply the patch.
 2. Navigate to Appearance > Themes and ensure that a classic theme is
 activated.
 3. Navigate to Appearance > Theme File Editor.
 4. Open the functions.php file and add echo 'Howdy, admin!';. Click Update
 File.
 5. Remove the, and click Update File.
 6. Navigate to Plugins > Plugin File Editor.
 7. Open the main plugin file for an active plugin and add echo 'Howdy,
 admin!';. Click Update File.
 8. Remove the; and click Update File.


 === Expected Results
 1. ✅ The theme file should be updated successfully.
 2. ✅ The theme file should fail to update.
 3. ✅ The plugin file should be updated successfully.
 4. ✅ The plugin file should fail to update.

 === Actual Results
 1. ✅ The theme file was updated successfully.
 2. ✅ The theme file fails to update.
 3. ✅ The plugin file was updated successfully.
 4. ✅ The plugin file fails to update.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57725#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list