[wp-trac] [WordPress Trac] #61111: Add support for column and row span in grid layout child blocks.

[WordPress Trac]

#61111: Add support for column and row span in grid layout child blocks.
-----------------------------------------+----------------------------
 Reporter:  isabel_brison                |       Owner:  isabel_brison
     Type:  enhancement                  |      Status:  reopened
 Priority:  normal                       |   Milestone:  6.6
Component:  Editor                       |     Version:  trunk
 Severity:  normal                       |  Resolution:
 Keywords:  gutenberg-merge needs-patch  |     Focuses:
-----------------------------------------+----------------------------
Changes (by peterwilsoncc):

 * keywords:  gutenberg-merge has-patch => gutenberg-merge needs-patch
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I'm seeing an error running phpunit that a bisect shows is coming from
 this commit.

 It appears to be coming from the
 `Test_Block_Supports_Layout::data_wp_add_parent_layout_to_parsed_block()`
 class which registers `parent_block` without a `blockName` property.

 I'm unclear whether the regression is in the test suite or a change to
 graceful handling when registering blocks.


 {{{
 $ ./vendor/bin/phpunit --group dont-run-tests
 Installing...
 Running as single site... To run multisite, use -c
 tests/phpunit/multisite.xml
 Not running ajax tests. To execute these, use --group ajax.
 Not running ms-files tests. To execute these, use --group ms-files.
 Not running external-http tests. To execute these, use --group external-
 http.

 Notice: Undefined index: blockName in /vagrant/wordpress-develop/src/wp-
 includes/class-wp-block.php on line 131

 Call Stack:
     0.0079     411184   1. {main}() /vagrant/wordpress-
 develop/vendor/bin/phpunit:0
     0.0100     425440   2. include('phpvfscomposer:///vagrant/wordpress-
 develop/vendor/phpunit/phpunit/phpunit') /vagrant/wordpress-
 develop/vendor/bin/phpunit:118
 ...snip...
     2.3503   50577920  17.
 Test_Block_Supports_Layout->data_wp_add_parent_layout_to_parsed_block()
 /vagrant/wordpress-
 develop/vendor/phpunit/phpunit/src/Util/Annotation/DocBlock.php:421
     2.3503   50578896  18. WP_Block->__construct($block = ['attrs' =>
 ['layout' => ['type' => 'grid']]], $available_context = ???, $registry =
 ???) /vagrant/wordpress-develop/tests/phpunit/tests/block-
 supports/layout.php:446

 PHPUnit 9.6.19 by Sebastian Bergmann and contributors.

 Warning:       Your XML configuration validates against a deprecated
 schema.
 Suggestion:    Migrate your XML configuration using "--migrate-
 configuration"!

 No tests executed!
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61111#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform