[wp-trac] [WordPress Trac] #59754: Twenty Sixteen: Pullquote block having issues with border and spacing (was: Twenty Sixteen Pullquote block having issue with the border design.)
WordPress Trac
noreply at wordpress.org
Thu May 23 20:55:04 UTC 2024
#59754: Twenty Sixteen: Pullquote block having issues with border and spacing
------------------------------+-----------------------------
Reporter: nidhidhandhukiya | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Future Release
Component: Bundled Theme | Version: 5.4
Severity: normal | Resolution:
Keywords: has-patch | Focuses: css
------------------------------+-----------------------------
Changes (by sabernhardt):
* keywords: has-patch changes-requested => has-patch
* focuses: => css
* version: 6.3.2 => 5.4
* milestone: Awaiting Review => Future Release
Comment:
==== Removing extra border on the `blockquote` element
I agree that the default left (or right) border is a bug, and that it
would be worth fixing even after four years. For anyone who has removed
the top and bottom borders in custom CSS, relying on the `blockquote`
border, we would need to mention any change in a dev note.
History: The border changes in [47273] did not match the style from
WordPress 5.0 to 5.3. WordPress 5.4 removed the `editor-block-list__block`
class, so the theme did not
[https://core.trac.wordpress.org/browser/trunk/src/wp-
content/themes/twentysixteen/css/editor-blocks.css?rev=57577#L502 reset]
the border, margin and padding. Then trying to solve a discrepancy by
matching the front end to the editor established the unintended style in
both places.
==== Not restoring the original design with the top border
If the bottom border is removed and/or the Pullquote //block// begins to
float in a future update, I do not think anyone would expect that. Maybe
that could have been a registered block style, but now that would be a new
feature in an old theme.
==== Negative margin
The negative margin does not seem to fit Pullquote blocks well (though it
//might// be appreciated with Quote blocks). In the pull request, I set
the left and right margins to zero if the `blockquote` is inside a
Pullquote block.
{{{
.entry-content .wp-block-pullquote
blockquote:not(.alignleft):not(.alignright) {
margin-left: 0;
margin-right: 0;
}
}}}
==== Margin/padding around quote when the block has left and/or right
borders
When adding a border in the block settings, the text can touch the left
and right sides. The Pullquote block does not have a Padding setting, but
I do not think that the block should add space for all Pullquote blocks to
accommodate this situation. **Maybe** it could add padding only if the
block has a `border-width`, similar to this:
{{{
.wp-block-pullquote:where([style*="border-width"]) blockquote {
padding-left: 1rem;
padding-right: 1rem;
}
}}}
I made a pull request so it would be easier to choose some changes instead
of all.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/59754#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list