[wp-trac] [WordPress Trac] #61229: Twenty Seventeen: "undefined is not an object" in JS detection

WordPress Trac noreply at wordpress.org
Sun May 19 04:48:25 UTC 2024


#61229: Twenty Seventeen: "undefined is not an object" in JS detection
---------------------------+------------------------------
 Reporter:  domainsupport  |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:  6.5.3
 Severity:  normal         |  Resolution:
 Keywords:  needs-testing  |     Focuses:  javascript
---------------------------+------------------------------
Changes (by sabernhardt):

 * keywords:   => needs-testing
 * focuses:   => javascript


Comment:

 Thanks for the report!

 This will need testing in Safari for multiple themes.

 Three default themes use the same script to replace the class on `html`:
 - [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyfifteen/functions.php?rev=57180#L415 Twenty Fifteen]
 - [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentysixteen/functions.php?rev=57180#L376 Twenty Sixteen]
 - [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyseventeen/functions.php?rev=57180#L409 Twenty
 Seventeen]

 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentytwenty/inc/template-tags.php?rev=57180#L654 Twenty
 Twenty] similarly replaces the `no-js` class, but not in the same way.
 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentytwentyone/inc/template-functions.php?rev=57180#L77
 Twenty Twenty-One] just removes `no-js` from the (body) class list.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61229#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list