[wp-trac] [WordPress Trac] #61182: Normalize UTF-8 charset slug detection.

WordPress Trac noreply at wordpress.org
Wed May 15 00:49:49 UTC 2024


#61182: Normalize UTF-8 charset slug detection.
--------------------------------------+-----------------------
 Reporter:  dmsnell                   |       Owner:  dmsnell
     Type:  enhancement               |      Status:  reopened
 Priority:  normal                    |   Milestone:  6.6
Component:  General                   |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-----------------------

Comment (by dmsnell):

 it could @SergeyBiryukov, but there are a few reasons I think it may be
 fine to leave.

  - `load.php` is already 2000 lines and can be slow in an IDE to work in
 if the IDE is applying styling lints and code sniffs.
  - there are many other common Unicode-related functions that I think fit
 there, including some that are already scattered and duplicated among
 `kses` and `formatting` and elsewhere.
  - "unicode" is a somewhat well-formed category on its own. If looking for
 some related functionality I might look for a `string.php`, `strings.php`,
 `utf8.php `, or `unicode.php` but wouldn't think to lookup `load.php`

 Happy to adapt; just wanted to share that when I proposed this I did
 consider leaving it even inside of `functions.php` where
 `_canonical_charset()` lives, but for similar reasoning felt it was a good
 fit for a new home.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61182#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list