[wp-trac] [WordPress Trac] #61182: Normalize UTF-8 charset slug detection.
WordPress Trac
noreply at wordpress.org
Tue May 14 18:03:59 UTC 2024
#61182: Normalize UTF-8 charset slug detection.
--------------------------------------+----------------------
Reporter: dmsnell | Owner: dmsnell
Type: enhancement | Status: closed
Priority: normal | Milestone: 6.6
Component: General | Version: trunk
Severity: normal | Resolution: fixed
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+----------------------
Changes (by dmsnell):
* owner: (none) => dmsnell
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"58147" 58147]:
{{{
#!CommitTicketReference repository="" revision="58147"
Normalize UTF-8 charset slug detection.
There are several exist places in Core that attempt to detect if a blog
charset
is UTF-8. Each place attempts to perform the same check, except the logic
is
spread throughout and there's no single method provided to make this
determination in a consistent way. The `_canonical_charset()` method
exists,
but is marked private for use.
In this patch the new `unicode` module provides `is_utf8_charset()` as a
method
taking an optional charset slug and indicating if it represents UTF-8,
examining all of the allowable variants of that slug. Associated code is
updated to use this new function, including `_canonical_charset()`. If no
slug
is provided, it will look up the current `get_option( 'blog_charset' )`.
Finally, the test functions governing `_canonical_charset()` have been
rewritten as a single test with a data provider instead of as separate
test
functions.
Developed in https://github.com/WordPress/wordpress-develop/pull/6535
Discussed in https://core.trac.wordpress.org/ticket/61182
Fixes #61182.
Props dmsnell, jonsurrell.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/61182#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list