[wp-trac] [WordPress Trac] #49950: Twenty Twenty: with horizontal menu, submenu should be dismissible

WordPress Trac noreply at wordpress.org
Mon May 6 09:41:56 UTC 2024


#49950: Twenty Twenty: with horizontal menu, submenu should be dismissible
----------------------------------+----------------------------------------
 Reporter:  lcarevic              |       Owner:  joedolson
     Type:  defect (bug)          |      Status:  assigned
 Priority:  normal                |   Milestone:  6.6
Component:  Bundled Theme         |     Version:
 Severity:  normal                |  Resolution:
 Keywords:  needs-testing has-    |     Focuses:  accessibility, javascript
  patch                           |
----------------------------------+----------------------------------------
Changes (by rcreators):

 * keywords:  needs-testing has-patch changes-requested needs-refresh =>
     needs-testing has-patch


Comment:

 Hello @joedolson and @poena,

 So I found the issue that @poena talked about. It happens when there is a
 multi-level sub-menu. I adjusted the code to make it work in that
 situation as well.

 Apart from that, if you move back with the shift + Tab, as the sub-menu is
 already out of focus, it will focus on the parent menu item and then you
 can move to the sub-menu item with tabbing. Let me know if you want to
 change that function. It can be just updated with visibility CSS.

 I also added a focusout event for the menu. So if the user clicks or does
 any event outside of the menu, the sub-menu will close down as well.

 Please test this out and let me know if any further changes are required.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49950#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list