[wp-trac] [WordPress Trac] #42598: Twenty Seventeen: Sticky header offset issue

WordPress Trac noreply at wordpress.org
Mon May 6 09:35:29 UTC 2024


#42598: Twenty Seventeen: Sticky header offset issue
-------------------------------------+-----------------------------
 Reporter:  anevins                  |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Bundled Theme            |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  javascript
-------------------------------------+-----------------------------
Changes (by poena):

 * keywords:  has-patch needs-testing => has-patch needs-refresh


Comment:

 At first, I got confused because it says that the theme has an option for
 enabling a sticky menu.
 I tried to look for an actual option in the Customizer, but did not find
 one.
 So I assume the sticky menu is the default behavior when a menu is
 assigned to the "Top Menu" menu location.

 I am able to reproduce the issue on WordPress trunk on Windows 11 using
 Chrome and Firefox.

 Patch
 https://core.trac.wordpress.org/attachment/ticket/42598/%2342598.patch
 can not be applied, it seems it is missing the path to the file.
 When I add the changes manually to the file, it solves the problem. I get
 somewhat different results in Chrome and Firefox, it does not scroll to
 the exact same position.
 I do not see a visible "second" layout shift, like in the videos shared in
 the ticket.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42598#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list