[wp-trac] [WordPress Trac] #21077: Add support for custom ports in multisite site addresses
WordPress Trac
noreply at wordpress.org
Sat May 4 19:03:37 UTC 2024
#21077: Add support for custom ports in multisite site addresses
--------------------------------------------+--------------------------
Reporter: djzone | Owner: johnbillion
Type: enhancement | Status: reviewing
Priority: normal | Milestone: 6.6
Component: Bootstrap/Load | Version: 3.4
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests early | Focuses: multisite
--------------------------------------------+--------------------------
Comment (by johnbillion):
I am going to commit [https://github.com/WordPress/wordpress-
develop/pull/5675 PR 5675] to introduce support for port numbers to
Multisite. Before I do, some notes:
* A concern in the discussion above is where in the database to store the
port number, and the changes that would be required throughout the core
codebase if it was stored in the `wp_blogs.domain` field. If you take a
look at PR 5675 you'll see that actually there are very few places in core
that need to be changed to support port numbers on Multisite, and most of
the changes are small adjustments. Certainly nothing fundamental. Storing
the port number elsewhere, for example in site meta, wouldn't negate the
need for these changes and in fact would add additional complexity. That's
why I support including the port number in `wp_blogs.domain`.
* The test suite has been updated to allow all the tests to run on a site
with a port in its URL (via the `LOCAL_WP_TESTS_DOMAIN` environment
variable) both on Multisite and single-site. A few bugs with port handling
were found and fixed as a result. Don't forget to always use the
`WP_TESTS_DOMAIN` constant in tests instead of a hardcoded `example.org`.
* This fixes #52088 too which allows the local development environment to
run a Multisite installation. Set the `LOCAL_MULTISITE` environment
variable to `true` during provisioning to enable this.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/21077#comment:45>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list