[wp-trac] [WordPress Trac] #59251: Site Health incorrectly reports low disk space available for updates when disk_free_space function disabled

[WordPress Trac]

#59251: Site Health incorrectly reports low disk space available for updates when
disk_free_space function disabled
-------------------------------+------------------------------
 Reporter:  sdowney2002        |       Owner:  (none)
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Site Health        |     Version:  6.3.1
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:
-------------------------------+------------------------------

Comment (by ironprogrammer):

 Hi, @website-rob -- Disabling `disk_free_space` is an [comment:2 example
 step] to help find a way to consistently reproduce the issue, but is not
 an attempt to solve the problem. Thank you for noting the missing
 `upgrade` directory context, since that is, indeed, another instance that
 could cause this check to report an issue.

 FWIW, I've re-tested after deleting the directory (in my environment,
 `/wp-content/upgrade/`), but received the expected, "Could not determine
 available disk space for updates." I could only trigger the critical
 warning message when overriding `disk_free_space` to return < 20 MB.

 I've updated the test gist in comment:6 to include a check whether
 `upgrade` exists, and if `disk_free_space` has been overridden (not the
 internal function). It's hard to track down issues in specific hosting
 setups, so any test results feedback from those who reported seeing this
 issue would be appreciated 🙏🏻

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59251#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform