[wp-trac] [WordPress Trac] #60992: Plugin management: AJAX plugin activation consequences

[WordPress Trac]

#60992: Plugin management: AJAX plugin activation consequences
-------------------------------------------------+-------------------------
 Reporter:  jeherve                              |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.5.3
Component:  Plugins                              |     Version:  6.5
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info needs-design-feedback commit      |
  i18n-change                                    |
-------------------------------------------------+-------------------------

Comment (by ironprogrammer):

 Thanks, everyone, for all the effort put into this so far! 🙌🏻

 == Test Report
 Patch tested: https://github.com/WordPress/wordpress-develop/pull/6401
 Testing instructions:
 https://core.trac.wordpress.org/ticket/60992#comment:47

 === Environment
 - Hardware: MacBook Pro Apple M1 Pro
 - OS: macOS 14.4.1
 - Browser: Safari 17.4.1, Google Chrome 124.0.6367.94
 - Server: nginx/1.25.5
 - PHP: 8.2.18
 - MySQL: 8.0.27
 - WordPress: 6.6-alpha-57778-src
 - Plugin used for testing: WooCommerce (WC)

 === Actual Results
 - ✅ Activation from Installed Plugins page (main list) redirects to WC
 setup.
 - ✅ Activation from Add Plugins page shows admin notice to refresh
 (''Figure 1''),
 - ✅ Activation from Add Plugins > More Details modal shows notice to
 refresh in footer of modal (''Figure 2'').
 - ✅ Clicking the notices' "Refresh Now" buttons began the WC plugin
 setup, or refreshed the page when setup had already been
 started/completed.
 - ⚠️ After new WC activation, opening the More Details modal **before**
 "refreshing" (via notice button, navigation, or manual refresh) results in
 the WC plugin setup wizard starting inside the modal. This could affect
 compatibility with plugin post-install redirects, though, to be honest,
 I'm unsure if this is an implementation bug or should be resolved by
 extenders. [https://cloudup.com/iinff1DPt3D See this link for a
 demonstration of this unexpected behavior].

 === Additional Notes
 - Used `wp transient set _wc_activation_redirect 1` between tests to mimic
 a
 [https://github.com/woocommerce/woocommerce/blob/de91a0881d7df32573b107507f9f836897832612/plugins/woocommerce/includes
 /class-wc-install.php#L618 new WC install].
 - Safari + 1Password extension users may experience an issue whereby the
 new notice does NOT appear. If your JS console has the error `Retrieving
 "b5x-stateful-inline-icon" flag errored: timed out - falling back`, this
 is due to a [https://1password.community/discussion/145003/console-error-
 retrieving-b5x-stateful-inline-icon-flag-errored-timed-out-falling-back
 known 1P extension bug]. Disable the extension to work around the issue.

 === Supplemental Artifacts
 ''Figure 1: New admin notice in header.''
   [[Image(https://cldup.com/ItyZ4vIQEE.png)]]

 ''Figure 2: New notice in modal footer.''
   [[Image(https://cldup.com/tN5uU_6nR1.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60992#comment:88>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform