[wp-trac] [WordPress Trac] #42957: Usernames ending in a period generate invalid reset password links in certain email clients

[WordPress Trac]

#42957: Usernames ending in a period generate invalid reset password links in
certain email clients
-------------------------------------------------+-------------------------
 Reporter:  paulcline                            |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.6
Component:  Users                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-dev-  |     Focuses:
  note dev-feedback                              |
-------------------------------------------------+-------------------------

Comment (by daveagp):

 Thank you @oglekler !

 Ok, I didn't exactly know the details of comments on the second PR which
 copied mine but from the right trunk. I've tried again in
 https://github.com/WordPress/wordpress-develop/pull/6834/files and renamed
 it according to a comment I saw. I didn't get a notice of the comments on
 the second PR since it wasn't mine but hopefully I'll see any on this 3rd
 one.

 The comments on 2nd PR also say "If this function remains, it should be a
 core-only private function". I don't know if that is already true or not,
 but if important, I'd need a hint on what concretely to change, thank you
 in advance.

 I agree that `str_replace` would work, but given that periods mid-user
 name are extremely common and unproblematic for all email clients (I've
 got many user reports from the trailing period but none from any other
 position), my thinking is not to unnecessarily create mumbo jumbo in their
 invitation emails.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42957#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform