[wp-trac] [WordPress Trac] #59801: Twenty Fifteen: Pullquote block issues with text color and border (was: The pullquote block text color and border issue into the theme Twenty Fifteen)

[WordPress Trac]

#59801: Twenty Fifteen: Pullquote block issues with text color and border
-----------------------------------+-----------------------------
 Reporter:  viralsampat            |       Owner:  (none)
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  Future Release
Component:  Bundled Theme          |     Version:  6.3.2
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  css
-----------------------------------+-----------------------------
Changes (by sabernhardt):

 * keywords:  has-patch needs-refresh reporter-feedback => has-patch 2nd-
     opinion


Comment:

 ==== Border

 Both patch options edit the border styles the same ways.

 1. The `blockquote` element should not have its own border. The editor
 shows one because the `.editor-block-list__block` class is obsolete and
 the selector needs to be replaced. (The extra border was also mentioned on
 #59612, but its latest patch only includes border color classes for the
 theme.)
 2. I added a default border style of `solid` for the block so people would
 not need to use that control for the most common style.

 ==== Text Color

 The default text color for this theme originally had a lighter gray for
 quotes, including the Pullquote block, and then it set the citation to the
 body color again.
 {{{
 blockquote {
   color: #707070;
   color: rgba(51, 51, 51, 0.7);
 }
 .wp-block-pullquote cite,
 blockquote cite,
 blockquote small {
   color: #333; /* body color */
 }
 }}}

 However, WordPress 5.9 (GB30951) made the Pullquote's elements inherit the
 block color on the front end (except when a theme uses a higher
 specificity or sets the color later in the cascade) more than two years
 ago.
 {{{
 .wp-block-pullquote p,
 .wp-block-pullquote blockquote,
 .wp-block-pullquote cite {
   color: inherit;
 }
 }}}

 Since 6.4, the iframe editor has also inherited the body color, so some
 people might not know that the colors were ever different. This could be
 considered an established design change, though unintentional.

 [attachment:"59801.re-establish-color.patch"]: I am not entirely
 comfortable with reassigning the color to the block container to re-
 establish the original design, but I made a patch to show how it might
 work.
 - Sets semi-transparent gray (with fallback) on `.wp-block-pullquote` (and
 `blockquote` within the editor)
 - Makes `blockquote` inherit any custom Text color
 - Makes citation inherit the text color when a user chooses a different
 Background color (setting either a Text or Background color on the
 Pullquote does not necessarily mean that the user wanted the citation
 color to match the quote, but a dark Background requires the ability to
 change the citation color)

 [attachment:"59801.inherit-all.patch"] would officially establish the
 matching colors with this theme.
 - Makes both the `blockquote` and the citation inherit the text color from
 their containers
 - Removes Pullquote-related changes from [58368]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59801#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform