[wp-trac] [WordPress Trac] #61400: `wp_get_plugin_action_button()` can return `void`.

WordPress Trac noreply at wordpress.org
Sun Jun 9 00:19:16 UTC 2024


#61400: `wp_get_plugin_action_button()` can return `void`.
---------------------------------------------+---------------------
 Reporter:  costdev                          |       Owner:  (none)
     Type:  defect (bug)                     |      Status:  new
 Priority:  normal                           |   Milestone:  6.6
Component:  Plugins                          |     Version:  6.5
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch has-unit-tests commit  |     Focuses:
---------------------------------------------+---------------------
Changes (by rajinsharwar):

 * keywords:  has-patch has-unit-tests => has-patch has-unit-tests commit


Comment:

 For ease of testing this, I have just inversed the capability check so
 that I can test the patch with the admin user.

 1. Before Patch, the call to **wp_get_plugin_action_button()** is
 returning void: https://prnt.sc/pOTrSJ8-nVOG ✅
 2. After Patch, the call to **wp_get_plugin_action_button()** is returning
 an empty string: https://prnt.sc/oi7IqWLBNhVq ✅

 This is now working to return a string irrespective of the result of the
 capability check. Marking this for 'commit' as it has both manual and unit
 tests passed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61400#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list