[wp-trac] [WordPress Trac] #60799: Change the Header Tag in Link Modal from <h1> to <h2> for Better Accessibility

[WordPress Trac]

#60799: Change the Header Tag in Link Modal from <h1> to <h2> for Better
Accessibility
-------------------------------------------------+-------------------------
 Reporter:  lyonmuller                           |       Owner:  jwgoedert
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.6
Component:  Editor                               |     Version:  6.4.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info                                   |  accessibility
-------------------------------------------------+-------------------------
Changes (by joedolson):

 * keywords:   => has-patch needs-testing has-testing-info


Comment:

 - The Insert/edit link modal does not use the `aria-modal` attribute (no
 surprise, since it predates the attribute's support significantly)
 - The page is not made inert, and does not use `aria-hidden`.

 Patch incoming shortly that implements both.

 Testing info:
  - Enable classic editor
  - Add text, initiate a link.
  - Click on the 'gear' icon to trigger the link insertion modal.
  - Observe that the modal container has the attribute `aria-modal="true"`
 and `#wpwrap` has the attribute `aria-hidden="true"`. There are other
 elements that are children of the body and not children of the modal, but
 they already have `display: none;` and have their states controlled
 elsewhere.
  - Observe that the `aria-hidden="true"` attribute is removed when the
 modal is closed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60799#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform