[wp-trac] [WordPress Trac] #46108: Twenty Nineteen: Include contributing.txt file with Sass compiler instructions

WordPress Trac noreply at wordpress.org
Sat Jun 8 18:25:25 UTC 2024


#46108: Twenty Nineteen: Include contributing.txt file with Sass compiler
instructions
-------------------------------------+-----------------------------
 Reporter:  kjellr                   |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Bundled Theme            |     Version:  5.0.3
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------------

Comment (by sabernhardt):

 The `npm run build` instruction could mention something about (possibly)
 running the command twice. At least for me, the RTL process can run on the
 old CSS file before compiling that from Sass files.

 Also, when I had a temporary problem with the deprecated `node-sass`, I
 thought to propose that we stop editing Twenty Nineteen's Sass files
 if/when the compiling fails to work. I don't like how much the main
 stylesheets could change when [https://github.com/sabernhardt/wordpress-
 develop/pull/33/files switching to Dart Sass] (without special
 configuration). Twenty Twenty-One already uses Dart Sass, so that theme
 should be fine.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46108#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list