[wp-trac] [WordPress Trac] #61348: HTML API: Report real and virtual nodes in the HTML Processor.

WordPress Trac noreply at wordpress.org
Sat Jun 8 12:10:58 UTC 2024


#61348: HTML API: Report real and virtual nodes in the HTML Processor.
--------------------------------------+----------------------
 Reporter:  dmsnell                   |       Owner:  dmsnell
     Type:  enhancement               |      Status:  closed
 Priority:  normal                    |   Milestone:  6.6
Component:  HTML API                  |     Version:  trunk
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+----------------------

Comment (by dmsnell):

 In [changeset:"58365" 58365]:
 {{{
 #!CommitTicketReference repository="" revision="58365"
 HTML API: Call `$this->is_tag_closer()` in HTML Processor.

 The HTML Processor had been calling the parent class `is_tag_closer()`
 method, but since visiting virtual nodes was introduced, it's important
 that all of the methods are called on the subclass.

 This patch fixes one issue identified where the parent method was called
 instead, and it fixes another case where the change from calling the
 parent method to the `$this` method was done improperly.

 Developed in https://github.com/WordPress/wordpress-develop/pull/6726
 Discussed in https://core.trac.wordpress.org/ticket/61348

 Props jonsurrell.
 See #61348.
 Follow-up to [58304].
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61348#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list