[wp-trac] [WordPress Trac] #61112: Avoid re-constructing `WP_Theme_JSON` object from raw theme_json, instead use `WP_Theme_JSON` object inside `WP_Theme_JSON_data`

WordPress Trac noreply at wordpress.org
Thu Jun 6 20:01:34 UTC 2024


#61112: Avoid re-constructing `WP_Theme_JSON` object from raw theme_json, instead
use `WP_Theme_JSON` object inside `WP_Theme_JSON_data`
-------------------------------------------------+-------------------------
 Reporter:  thekt12                              |       Owner:  thekt12
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.6
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-testing-info needs-    |     Focuses:
  testing                                        |  performance
-------------------------------------------------+-------------------------
Changes (by joemcgill):

 * keywords:  has-patch => has-patch has-testing-info needs-testing


Comment:

 Since GitHub code review comments don't come through here, I want to make
 [https://github.com/WordPress/wordpress-
 develop/pull/6626#discussion_r1628000330 this conversation] visible.

 Summary: It seems that this issue is only reproducible when this code is
 run alongside Gutenberg versions prior to 18.3, so we might close this and
 consider the bug fixed upstream.

 It would be useful to have someone confirm that this issue only
 reproducible when running GB 18.2 or lower with the Blocks Everywhere
 plugin, which returns a `WP_Theme_JSON_Data_Gutenberg` object from the
 `wp_theme_json_data_theme` filter, and that upgrading to GB 18.3 solves
 the issue.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61112#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list