[wp-trac] [WordPress Trac] #58932: wp_setup_nav_menu_item() throws PHP warning when using virtual menu-items

[WordPress Trac]

#58932: wp_setup_nav_menu_item() throws PHP warning when using virtual menu-items
-----------------------------------------+------------------------------
 Reporter:  apedog                       |       Owner:  joemcgill
     Type:  defect (bug)                 |      Status:  reviewing
 Priority:  normal                       |   Milestone:  Awaiting Review
Component:  Menus                        |     Version:  5.4
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch reporter-feedback  |     Focuses:
-----------------------------------------+------------------------------
Changes (by joemcgill):

 * keywords:  has-patch => has-patch reporter-feedback


Comment:

 Thanks @apedog. This change makes sense to me since `get_post()` can
 return `null` on failure. I've refreshed the diff in this PR so we can
 make sure tests are passing. It would be great to add an additional unit
 test that would demonstrate the bug.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58932#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform