[wp-trac] [WordPress Trac] #61372: Twenty Seventeen: Search Block Clear text button not showing on frontend

[WordPress Trac]

#61372: Twenty Seventeen: Search Block Clear text button not showing on frontend
-------------------------------+------------------------------
 Reporter:  pranitdugad        |       Owner:  (none)
     Type:  defect (bug)       |      Status:  reopened
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Bundled Theme      |     Version:
 Severity:  trivial            |  Resolution:
 Keywords:  close 2nd-opinion  |     Focuses:
-------------------------------+------------------------------
Changes (by sabernhardt):

 * keywords:   => close 2nd-opinion
 * severity:  minor => trivial


Comment:

 Twenty Seventeen removes the browser's search cancel button from the front
 end as part of the `normalize` style set.
 [https://github.com/WordPress/twentyseventeen/commit/afc1707e8cf51757cdb367db21e37b9efab6c4fa
 #diff-b78be019f1dc6d57753ea900c3805b114cd53ab7c0db836cc081836df1b99b7aL226
 PR 92] updated those styles, so I would say that the theme should continue
 to remove the button from the front end.

 The editor styles theoretically could be updated with the same ruleset,
 but
 1. I think the cancel button can be useful when starting to write a
 `placeholder` attribute and then deciding to remove it,
 2. the button only appears in the editor when someone types in an optional
 placeholder (and on hover/focus after it has a placeholder), and
 3. the theme does not set its more noticeable styles related to forms
 within the editor (#45293).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61372#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform