[wp-trac] [WordPress Trac] #61430: Adding escaping function in wp_interactivity_data_wp_context PHPDoc

WordPress Trac noreply at wordpress.org
Wed Jul 31 20:56:57 UTC 2024


#61430: Adding escaping function in wp_interactivity_data_wp_context PHPDoc
--------------------------------------+-----------------------
 Reporter:  mosne                     |       Owner:  audrasjb
     Type:  enhancement               |      Status:  accepted
 Priority:  normal                    |   Milestone:  6.6.2
Component:  Interactivity API         |     Version:  6.5
 Severity:  minor                     |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  docs
--------------------------------------+-----------------------

Comment (by dmsnell):

 Both open PRs are attempting to escape the content, which will likely
 introduce corruption into the interactivity data.

 @hellofromTonya please let's reject both patches as proposed.

 On the other hand, a documentation update to this function would be
 helpful, and should be easy to approve. There is no outstanding defect if
 I'm interpreting this correct, so there are no code changes to resolve
 this ticket, and nothing to test.

 The only thing that's necessary is ensuring that our coding standards
 aren't accidentally encouraging people to introduce breakage by applying
 rules where they aren't appropriate, such as in this case where that seems
 to have occurred (again). Hopefully someone on this ticket can rearrange
 their patch to reflect this.

 Maybe someone with more experience in the WPCS domain could help by
 proposing a rule change to exempt this function?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61430#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list