[wp-trac] [WordPress Trac] #60414: Core PHP autoloader proposal
WordPress Trac
noreply at wordpress.org
Wed Jul 31 17:37:00 UTC 2024
#60414: Core PHP autoloader proposal
-------------------------------------+-------------------------------------
Reporter: aristath | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit- | Focuses: performance,
tests early | sustainability
-------------------------------------+-------------------------------------
Comment (by hellofromTonya):
Sharing a summary from a discussion that happened in the
[https://wordpress.slack.com/archives/C18723MQ8/p1722357171594079 Making
WordPress core-committers Slack channel]:
@spacedmonkey asked:
>What is the process of getting a ticket as big as #60414 committed? What
is needed to make the core committer feel confidence in the change? Would
a change like this need two or more committers to sign it off?
@costdev shared:
>Good question. While I don't have a specific number of committers in
mind, I'd say at least 3-4 committers should have reviewed/tested this
since it's sort of a big change (in additon to other reviewers/testers).
Maybe also looking to WP-CLI and similar to ensure no unexpected impacts
are felt.
@hellofromTonya shared:
>In addition, IMO Core Tech Lead(s) (for the targeted major release)
should approve or at least give the okay for it to be included in the
major.
>
>For this kind of big refactoring change, approval should happen as early
as possible in the alpha cycle. Doing so will give plenty of time for
feedback and follow-ups.
@jorbin shared:
>If you look at the [38571] refactoring of hooks as a similiar sized risk,
that had 8 committers propped. I'm not sure that exact number is needed,
but it does show there was a wide amount of testing.
>
>The associated ticket #17817 also shows a couple of things that I think
will help:
>1. Getting the patch on a dotorg sandbox and making sure it doesn't blow
up .org.
>2. Getting this on a large host so we can see how it performs in the
myriad conditions core runs
>3. Making sure that wp-cli doesn't break
>
>I think 3-4 committers that are willing to usher it through the release
as the likelihood of there being breakage is decent and having more folks
very familiar is super helpful.
>
>I also think there are unresolved concerns on
[https://make.wordpress.org/core/2024/02/01/proposal-implement-a-php-
autoloader-in-wordpress-core/ the make/core post] that make me think we
aren't at consensus on if this is a good idea.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/60414#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list