[wp-trac] [WordPress Trac] #37454: get_avatar_data() delivers different url for scheme=https and is_ssl()

[WordPress Trac]

#37454: get_avatar_data() delivers different url for scheme=https and is_ssl()
----------------------------------------+----------------------------
 Reporter:  neoxx                       |       Owner:  peterwilsoncc
     Type:  defect (bug)                |      Status:  closed
 Priority:  normal                      |   Milestone:  6.7
Component:  Users                       |     Version:  4.3
 Severity:  normal                      |  Resolution:  fixed
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+----------------------------
Changes (by peterwilsoncc):

 * owner:  (none) => peterwilsoncc
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"58822" 58822]:
 {{{
 #!CommitTicketReference repository="" revision="58822"
 Users: Always use HTTPS URLs for Gravatar links.

 Modifies gravatar image URLs to always use the HTTPS version from
 secure.gravatar.com.

 Gravatar now redirects HTTP image requests to their HTTPS equivalent,
 resulting in redirects for sites running over an HTTP connection
 (`is_ssl() === false`). Since the introduction of HTTP/2 the use of sub-
 domains for different hashes ([1-3].gravatar.com) now represents a
 performance hinderance rather than improvement.

 The scheme passed to `get_avatar_data()` is now ignored for the generation
 of Gravatar URLs but the setting retained to avoid introducing bugs for
 sites using either local avatars or third party providers.

 Props neoxx, SergeyBiryukov, sippis, peterwilsoncc, mukesh27, costdev,
 dd32.
 Fixes #37454.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37454#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform