[wp-trac] [WordPress Trac] #57368: Twenty Twenty-Three: unnecessary borders for linked images in Whisper variation
WordPress Trac
noreply at wordpress.org
Wed Jul 24 15:10:49 UTC 2024
#57368: Twenty Twenty-Three: unnecessary borders for linked images in Whisper
variation
-------------------------------------------------+-------------------------
Reporter: colorful tones | Owner: (none)
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: Awaiting
| Review
Component: Bundled Theme | Version: 6.1
Severity: normal | Resolution:
Keywords: has-patch needs-testing needs- | Focuses: css
refresh |
-------------------------------------------------+-------------------------
Changes (by colorful tones):
* keywords: has-patch needs-testing => has-patch needs-testing needs-
refresh
Comment:
> PR 3795 removed the border from the linked Site Logo in a new
installation, but not in a site where I had already added a Site Logo
block in TT3's Whisper variation.
@sabernhardt you would have to change style variations to break the cache
and see the effects being updated. Basically, whenever I change something
in any of the `xxxxxxxx.json` theme files - I have to switch to a
different variation and then back to the variation I'm changing to bust
the cache and actually see the changes. I'm not sure how this stands in
core and is likely a separate issue worth exploring. I thought that at
some point there was an impact for setting `define( 'SCRIPT_DEBUG', true
);`, but that does not seem to be the case any more.
I've opened a new pull request, and I've addressed and tested all changes
against the Post Features Image, Image, Site Logo, and Gallery blocks to
verify that the border and background (on `:hover`) are fixed.
I'm having issues generating a patch, because it is outputting a ton of
stuff I have not changed. I'm going to seek guidance in Slack #core.
Also, I've been branching and testing against `trunk`. I'm not sure if we
need to update this ticket's Version, because right now it is marked for
`6.1`? 🤔
--
Ticket URL: <https://core.trac.wordpress.org/ticket/57368#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list