[wp-trac] [WordPress Trac] #56011: Twenty Twenty: Add support for Plain style in Quote block (was: Twenty Twenty: styles issue in Quote block)

[WordPress Trac]

#56011: Twenty Twenty: Add support for Plain style in Quote block
-------------------------------------+----------------------
 Reporter:  kajalgohel               |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  6.7
Component:  Bundled Theme            |     Version:  5.9
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, css
-------------------------------------+----------------------
Changes (by sabernhardt):

 * version:  6.0 => 5.9
 * type:  defect (bug) => enhancement


Comment:

 GB29856 added the Plain style, and `block-library/theme.css` assigns
 `border: none` (only if the theme opts in to `wp-block-styles`). The
 style's original design involved padding without the border.

 To remove the border, I prefer `border-width: 0` instead of `border:
 none`, just in case the block might have special border controls in the
 future. Both [attachment:"56011.border.diff"] and [attachment:"56011
 .border-padding.diff"] use `border-width`.

 Padding:
 - [attachment:"56011.border.diff"] keeps the current padding to avoid
 making a decision for other people.
 - With the lack of a difference between Default and Plain, I expect that
 few sites would have chosen the Plain option already. Changing the padding
 now likely would have little impact on existing sites' Quote blocks.
 - If the padding is edited, both the left and right padding probably
 should match. Then the CSS would use shorthand values instead of all four
 sides. In [attachment:"56011.border-padding.diff"], I chose to match the
 current left padding on the right side and to keep the same top and bottom
 values (`0.5rem 2rem` on the front, and the pixel equivalent `5px 20px` in
 the editor).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56011#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform