[wp-trac] [WordPress Trac] #46233: Multiple themes: Theme includes Screen Reader Text inside Card

WordPress Trac noreply at wordpress.org
Fri Jul 19 10:23:38 UTC 2024


#46233: Multiple themes: Theme includes Screen Reader Text inside Card
---------------------------+------------------------------
 Reporter:  dshanske       |       Owner:  karmatosed
     Type:  defect (bug)   |      Status:  assigned
 Priority:  low            |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:
 Severity:  trivial        |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------------------

Comment (by sabernhardt):

 Thanks for refreshing the patch! Reviewing that, I found an extra space I
 should not have added after `%1$s` in Twenty Sixteen.
 - That space is simply unnecessary following the avatar: \\
   `<span class="byline"><img alt=''
 src='http://0.gravatar.com/avatar/0309805bf7f3bc7b9a30f6e5c772475a?s=49&d=mm&r=g'
 srcset='http://0.gravatar.com/avatar/0309805bf7f3bc7b9a30f6e5c772475a?s=98&d=mm&r=g
 2x' class='avatar avatar-49 photo' height='49' width='49'
 decoding='async'/> <span class="screen-reader-text">Author </span><span
 class="author vcard"><a class="url fn n"
 href="http://localhost/svn/src/author/test/">tester</a></span></span>`
 - It makes the markup look wrong without avatars enabled: \\
   `<span class="byline"> <span class="screen-reader-text">Author
 </span><span class="author vcard"><a class="url fn n"
 href="http://localhost/svn/src/author/test/">tester</a></span></span>`

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46233#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list