[wp-trac] [WordPress Trac] #61457: Delay automatic updates after installation.

WordPress Trac noreply at wordpress.org
Wed Jul 10 16:17:02 UTC 2024


#61457: Delay automatic updates after installation.
------------------------------+-----------------------
 Reporter:  costdev           |       Owner:  costdev
     Type:  defect (bug)      |      Status:  reopened
 Priority:  normal            |   Milestone:  6.6
Component:  Upgrade/Install   |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------

Comment (by swissspidy):

 I primarily noticed it because the option ID changed, as the tests assume
 `siteurl` has the ID 1. While we can probably just adjust our tests, I am
 a bit concerned about other possible consequences of this change.

 Other tools/plugins could rely on `siteurl` having ID 1, and there is a
 potential risk because of all the cron-related filters running before the
 site is actually installed (no options or roles populated, etc.) and
 before any upgrade routines run. So if you have anything that hooks into
 those, they might not work correctly because the site isn't fully
 installed yet.

 I understand the need to add these cron changes earlier, but there is no
 reason for them to be _that_ early.

 While it still might be OK, I wanna flag this nonetheless.

 Apologies for not raising this earlier, but I was mostly out for the past
 few weeks.

 ----


 Generally speaking, it would be good to think more of WP-CLI when making
 changes to crucial parts such as the installation process. Maybe with core
 running WP-CLI tests or so.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61457#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list